[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/4] usb-mtp: use a list for keeping track of
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/4] usb-mtp: use a list for keeping track of children |
Date: |
Tue, 17 Nov 2015 12:54:01 +0100 |
Hi,
> + QLIST_FOREACH(iter, &o->children, list) {
> + usb_mtp_object_free(s, iter);
You have to use QLIST_FOREACH_SAFE here to avoid use-after-free on iter.
Or, as you free the whole list anyway, just grab QLIST_FIRST() while !
QLIST_EMPTY().
cheers,
Gerd