qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for 2.5] QEMU does not care about left shifts of


From: Laszlo Ersek
Subject: Re: [Qemu-devel] [PATCH for 2.5] QEMU does not care about left shifts of signed negative values
Date: Tue, 17 Nov 2015 11:52:17 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 11/17/15 11:43, Paolo Bonzini wrote:
> 
> 
> On 17/11/2015 11:41, Laszlo Ersek wrote:
>>> If and when this happens we will add "-fno-strict-overflow" for clang,
>>> just like we are using "-fno-strict-aliasing" already.
>>
>> How about adding "-fwrapv -fno-strict-overflow" right now? (Spelling out
>> the latter of those explicitly for pointer arithmetic.)
> 
> If it makes the change to HACKING more palatable, I'm all for it.

In general I'm not overly happy about this change :), but, if the
consensus is that we simply don't want to worry about this kind of UB in
QEMU, then let's actually prevent the compiler from exploiting the
standard's lenience, rather than just suppress the warning.

Thanks!
Laszlo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]