[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 5/7] aio: Introduce aio-epoll.c
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PULL v2 5/7] aio: Introduce aio-epoll.c |
Date: |
Mon, 16 Nov 2015 14:25:50 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, 11/13 18:09, Paolo Bonzini wrote:
> > +static void aio_epoll_update(AioContext *ctx, AioHandler *node, bool
> > is_new)
> > +{
> > + struct epoll_event event;
> > + int r;
> > +
> > + if (!ctx->epoll_enabled) {
> > + return;
> > + }
> > + if (!node->pfd.events) {
>
> Coverity says that node might have been freed by the time you call
> aio_epoll_update. You need to pass node->pfd.fd and node->pfd.events by
> value instead, I think, or move the call earlier in aio_set_fd_handler.
>
Yes, I'll send a patch.
Fam
- [Qemu-devel] [PULL v2 0/7] Block patches, Stefan Hajnoczi, 2015/11/09
- [Qemu-devel] [PULL v2 1/7] dataplane: simplify indirect descriptor read, Stefan Hajnoczi, 2015/11/09
- [Qemu-devel] [PULL v2 3/7] aio: Introduce aio_external_disabled, Stefan Hajnoczi, 2015/11/09
- [Qemu-devel] [PULL v2 2/7] dataplane: support non-contigious s/g, Stefan Hajnoczi, 2015/11/09
- [Qemu-devel] [PULL v2 4/7] aio: Introduce aio_context_setup, Stefan Hajnoczi, 2015/11/09
- [Qemu-devel] [PULL v2 5/7] aio: Introduce aio-epoll.c, Stefan Hajnoczi, 2015/11/09
- [Qemu-devel] [PULL v2 7/7] blockdev: acquire AioContext in hmp_commit(), Stefan Hajnoczi, 2015/11/09
- [Qemu-devel] [PULL v2 6/7] monitor: add missed aio_context_acquire into vm_completion call, Stefan Hajnoczi, 2015/11/09
- Re: [Qemu-devel] [PULL v2 0/7] Block patches, Peter Maydell, 2015/11/09
- Re: [Qemu-devel] [PULL v2 0/7] Block patches, Peter Maydell, 2015/11/09
- Re: [Qemu-devel] [PULL v2 0/7] Block patches, Marc-André Lureau, 2015/11/09
- Re: [Qemu-devel] [PULL v2 0/7] Block patches, Peter Maydell, 2015/11/09
- Re: [Qemu-devel] [PULL v2 0/7] Block patches, Marc-André Lureau, 2015/11/09
- Re: [Qemu-devel] [PULL v2 0/7] Block patches, Peter Maydell, 2015/11/10
- Re: [Qemu-devel] [PULL v2 0/7] Block patches, Peter Maydell, 2015/11/11
- Re: [Qemu-devel] [PULL v2 0/7] Block patches, Marc-André Lureau, 2015/11/11