[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 12/30] qapi-introspect: Document lack of sor
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v10 12/30] qapi-introspect: Document lack of sorting |
Date: |
Mon, 9 Nov 2015 13:56:58 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/06/2015 08:52 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> qapi-code-gen.txt already claims that types, commands, and
>> events share a common namespace; set this in stone by further
>> documenting that our introspection output will never have
>> collisions with the same name tied to more than one meta-type.
>>
>> For these reasons, we simply document that clients should not
>> rely on any particular order of items in introspection output.
>> And since it is now a documented part of the contract, we have
>> the freedom to later rearrange output if needed, without
>> worrying about breaking well-written clients that were already
>> aware that they had to do linear searches.
>
> Well, any kind of search that doesn't rely on sorting. Suggest to drop
> the "that were already..." clause. Happy to do that on commit.
I don't see that phrase dropped in your v1 pull request. Worth fixing?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v10 09/30] qapi: Test failure in middle of array parse, (continued)
- [Qemu-devel] [PATCH v10 09/30] qapi: Test failure in middle of array parse, Eric Blake, 2015/11/06
- [Qemu-devel] [PATCH v10 03/30] qobject: Protect against use-after-free in qobject_decref(), Eric Blake, 2015/11/06
- [Qemu-devel] [PATCH v10 08/30] qapi: More tests of alternate output, Eric Blake, 2015/11/06
- [Qemu-devel] [PATCH v10 02/30] qapi: Strengthen test of TestStructList, Eric Blake, 2015/11/06
- [Qemu-devel] [PATCH v10 04/30] qapi: Share test_init code in test-qmp-input*, Eric Blake, 2015/11/06
- [Qemu-devel] [PATCH v10 01/30] qapi: Use generated TestStruct machinery in tests, Eric Blake, 2015/11/06
- [Qemu-devel] [PATCH v10 14/30] qapi-types: Consolidate gen_struct() and gen_union(), Eric Blake, 2015/11/06
- [Qemu-devel] [PATCH v10 12/30] qapi-introspect: Document lack of sorting, Eric Blake, 2015/11/06
- [Qemu-devel] [PATCH v10 05/30] qapi: Plug leaks in test-qmp-*, Eric Blake, 2015/11/06
- [Qemu-devel] [PATCH v10 15/30] qapi-types: Simplify gen_struct_field[s], Eric Blake, 2015/11/06
- [Qemu-devel] [PATCH v10 16/30] qapi: Drop obsolete tag value collision assertions, Eric Blake, 2015/11/06
- [Qemu-devel] [PATCH v10 11/30] qapi: Provide nicer array names in introspection, Eric Blake, 2015/11/06
- [Qemu-devel] [PATCH v10 07/30] qapi: Simplify error cleanup in test-qmp-*, Eric Blake, 2015/11/06