[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 04/15] iotests: Move _filter_nbd into common.
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v6 04/15] iotests: Move _filter_nbd into common.filter |
|
Date: |
Mon, 9 Nov 2015 17:04:32 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 04.11.2015 um 19:57 hat Max Reitz geschrieben:
> _filter_nbd can be useful for other NBD tests, too, therefore it should
> reside in common.filter, and it should support URLs of the "nbd://"
> format and export names.
>
> The NBD log lines ("/your/source/dir/nbd.c:function():line: error")
> should not be converted to empty lines but removed altogether.
>
> Signed-off-by: Max Reitz <address@hidden>
Code motion and modification in the same patch is bad style. The changes
look good, though.
Kevin
[Qemu-devel] [PATCH v6 05/15] iotests: Make redirecting qemu's stderr optional, Max Reitz, 2015/11/04
[Qemu-devel] [PATCH v6 06/15] iotests: Add test for eject under NBD server, Max Reitz, 2015/11/04
[Qemu-devel] [PATCH v6 07/15] block: Move BDS close notifiers into BB, Max Reitz, 2015/11/04
[Qemu-devel] [PATCH v6 08/15] block: Use blk_remove_bs() in blk_delete(), Max Reitz, 2015/11/04