Re: [Qemu-devel] [PATCH qemu] spapr: Add /system-id

[David Gibson]

On Mon, Nov 09, 2015 at 05:47:17PM +1100, Alexey Kardashevskiy wrote:
> Section B.6.2.1 Root Node Properties of PAPR specification defines
> a set of properties which shall be present in the device tree root,
> one of these properties is "system-id" which "should be unique across
> all systems and all manufacturers". Since UUID is meant to be unique,
> it makes sense to use it as "system-id".
> 
> This adds "system-id" property to the device tree root when not empty.
> 
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> ---
> 
> This might be expected by AIX so here is the patch.
> I am really not sure if it makes sense to initialize property when
> UUID is all zeroes as the requirement is "unique" and zero-uuid is
> not.

Yeah, I think it would be better to omit system-id entirely when a
UUID hasn't been supplied.
> 
> ---
>  hw/ppc/spapr.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index de77528..e8b407d 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -374,6 +374,9 @@ static void *spapr_create_fdt_skel(hwaddr initrd_base,
>                            qemu_uuid[14], qemu_uuid[15]);
>  
>      _FDT((fdt_property_string(fdt, "vm,uuid", buf)));
> +    if (qemu_uuid_set) {
> +        _FDT((fdt_property_string(fdt, "system-id", buf)));
> +    }
>      g_free(buf);
>  
>      if (qemu_get_vm_name()) {

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature