[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v11 07/14] blockjob: Add "completed" and "ret" in Bl
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH v11 07/14] blockjob: Add "completed" and "ret" in BlockJob |
Date: |
Thu, 5 Nov 2015 18:13:13 -0500 |
From: Fam Zheng <address@hidden>
They are set when block_job_completed is called.
Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Signed-off-by: John Snow <address@hidden>
---
blockjob.c | 3 +++
include/block/blockjob.h | 9 +++++++++
2 files changed, 12 insertions(+)
diff --git a/blockjob.c b/blockjob.c
index ae9c5b2..bcd7efc 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -99,6 +99,9 @@ void block_job_completed(BlockJob *job, int ret)
BlockDriverState *bs = job->bs;
assert(bs->job == job);
+ assert(!job->completed);
+ job->completed = true;
+ job->ret = ret;
job->cb(job->opaque, ret);
block_job_unref(job);
}
diff --git a/include/block/blockjob.h b/include/block/blockjob.h
index ed856d7..c70d55a 100644
--- a/include/block/blockjob.h
+++ b/include/block/blockjob.h
@@ -153,6 +153,15 @@ struct BlockJob {
/** Reference count of the block job */
int refcnt;
+
+ /* True if this job has reported completion by calling block_job_completed.
+ */
+ bool completed;
+
+ /* ret code passed to block_job_completed.
+ */
+ int ret;
+
};
/**
--
2.4.3
- [Qemu-devel] [PATCH v11 00/14] block: incremental backup transactions using BlockJobTxn, John Snow, 2015/11/05
- [Qemu-devel] [PATCH v11 01/14] qapi: Add transaction support to block-dirty-bitmap operations, John Snow, 2015/11/05
- [Qemu-devel] [PATCH v11 02/14] iotests: add transactional incremental backup test, John Snow, 2015/11/05
- [Qemu-devel] [PATCH v11 06/14] blockjob: Add .commit and .abort block job actions, John Snow, 2015/11/05
- [Qemu-devel] [PATCH v11 07/14] blockjob: Add "completed" and "ret" in BlockJob,
John Snow <=
- [Qemu-devel] [PATCH v11 03/14] block: rename BlkTransactionState and BdrvActionOps, John Snow, 2015/11/05
- [Qemu-devel] [PATCH v11 05/14] blockjob: Introduce reference count and fix reference to job->bs, John Snow, 2015/11/05
- [Qemu-devel] [PATCH v11 04/14] backup: Extract dirty bitmap handling as a separate function, John Snow, 2015/11/05
- [Qemu-devel] [PATCH v11 09/14] block: Add block job transactions, John Snow, 2015/11/05
- [Qemu-devel] [PATCH v11 10/14] block/backup: Rely on commit/abort for cleanup, John Snow, 2015/11/05
- [Qemu-devel] [PATCH v11 13/14] iotests: 124 - transactional failure test, John Snow, 2015/11/05
- [Qemu-devel] [PATCH v11 14/14] tests: add BlockJobTxn unit test, John Snow, 2015/11/05
- [Qemu-devel] [PATCH v11 08/14] blockjob: Simplify block_job_finish_sync, John Snow, 2015/11/05
- [Qemu-devel] [PATCH v11 12/14] block: add transactional properties, John Snow, 2015/11/05
- [Qemu-devel] [PATCH v11 11/14] block: Add BlockJobTxn support to backup_run, John Snow, 2015/11/05