qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/11] snapshot: return error code from bdrv_sna


From: Denis V. Lunev
Subject: Re: [Qemu-devel] [PATCH 02/11] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name
Date: Thu, 5 Nov 2015 11:02:21 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 11/05/2015 10:55 AM, Greg Kurz wrote:
On Wed,  4 Nov 2015 20:19:33 +0300
"Denis V. Lunev" <address@hidden> wrote:

this will make code better in the next patch

This changelog is not very useful. IMHO this calls for squashing this patch
into the next one: then we clearly see how the return value is used and why
the code is better.

is it principal to get the series merged?

In general I have a strong opinion that non-functional changes
should be separated from functional ones. This makes review
faster and allows to concentrate on things where we can have
mistakes.

Den



reply via email to

[Prev in Thread] Current Thread [Next in Thread]