qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC 2/2] snapshot: create bdrv_snapshot_all_del_


From: Juan Quintela
Subject: Re: [Qemu-devel] [PATCH RFC 2/2] snapshot: create bdrv_snapshot_all_del_snapshot helper
Date: Wed, 04 Nov 2015 13:10:21 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

"Denis V. Lunev" <address@hidden> wrote:
> to delete snapshots from all loaded block drivers.
>
> The patch also ensures proper locking.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Juan Quintela <address@hidden>
> ---
>  block/snapshot.c         | 27 ++++++++++++++++++++++++
>  include/block/snapshot.h |  2 ++
>  migration/savevm.c       | 54 
> +++++++++---------------------------------------
>  3 files changed, 39 insertions(+), 44 deletions(-)
>
> diff --git a/block/snapshot.c b/block/snapshot.c
> index 6b5ce4e..9d1aa9b 100644
> --- a/block/snapshot.c
> +++ b/block/snapshot.c
> @@ -391,3 +391,30 @@ bool bdrv_snapshot_all_can_snapshot(BlockDriverState 
> **first_bad_bs)
>      *first_bad_bs = NULL;
>      return true;
>  }
> +
> +int bdrv_snapshot_all_del_snapshot(const char *name,

bdrv_snapshot_delete_all?
bdrv_snapshot_delete_all_snapshots?

Agreed with the patches.

Reviewed-by: Juan Quintela <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]