[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v9 17/27] qapi: Clean up after previous commit
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PATCH v9 17/27] qapi: Clean up after previous commit |
Date: |
Tue, 3 Nov 2015 23:20:39 -0700 |
From: Markus Armbruster <address@hidden>
QAPISchemaObjectTypeVariants.check() parameter members is no
longer used, drop it.
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
[Variant.check(seen) is used after all, so reword and reduce scope
of this patch; rearrange later in the series]
Signed-off-by: Eric Blake <address@hidden>
---
v9: new patch
---
scripts/qapi.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 4019389..3af5edb 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -991,7 +991,7 @@ class QAPISchemaObjectType(QAPISchemaType):
assert m.name not in seen
seen[m.name] = m
if self.variants:
- self.variants.check(schema, [], seen)
+ self.variants.check(schema, seen)
self.members = seen.values()
def is_implicit(self):
@@ -1046,7 +1046,7 @@ class QAPISchemaObjectTypeVariants(object):
self.tag_member = tag_member
self.variants = variants
- def check(self, schema, members, seen):
+ def check(self, schema, seen):
# seen is non-empty for unions, empty for alternates
if self.tag_name: # flat union
self.tag_member = seen[self.tag_name]
@@ -1086,7 +1086,7 @@ class QAPISchemaAlternateType(QAPISchemaType):
def check(self, schema):
self.variants.tag_member.check(schema)
- self.variants.check(schema, [], {})
+ self.variants.check(schema, {})
def json_type(self):
return 'value'
--
2.4.3
- [Qemu-devel] [PATCH RFC 5/5] Revert "qapi: allow override of default enum prefix naming", (continued)
- [Qemu-devel] [PATCH RFC 5/5] Revert "qapi: allow override of default enum prefix naming", Markus Armbruster, 2015/11/05
- [Qemu-devel] [PATCH RFC 3/5] qapi: Use common name mangling for enumeration constants, Markus Armbruster, 2015/11/05
- Re: [Qemu-devel] [PATCH RFC 3/5] qapi: Use common name mangling for enumeration constants, Daniel P. Berrange, 2015/11/05
- Re: [Qemu-devel] [PATCH RFC 3/5] qapi: Use common name mangling for enumeration constants, Eric Blake, 2015/11/05
- Re: [Qemu-devel] [PATCH RFC 3/5] qapi: Use common name mangling for enumeration constants, Eric Blake, 2015/11/05
- Re: [Qemu-devel] [PATCH RFC 3/5] qapi: Use common name mangling for enumeration constants, Markus Armbruster, 2015/11/06
- Re: [Qemu-devel] [PATCH RFC 3/5] qapi: Use common name mangling for enumeration constants, Markus Armbruster, 2015/11/06
- [Qemu-devel] What to do about QAPI naming convention violations (was: [PATCH RFC 3/5] qapi: Use common name mangling for enumeration constants), Markus Armbruster, 2015/11/10
- Re: [Qemu-devel] [PATCH RFC 3/5] qapi: Use common name mangling for enumeration constants, Markus Armbruster, 2015/11/09
- Re: [Qemu-devel] [PATCH RFC 3/5] qapi: Use common name mangling for enumeration constants, Daniel P. Berrange, 2015/11/09
[Qemu-devel] [PATCH v9 17/27] qapi: Clean up after previous commit,
Eric Blake <=
[Qemu-devel] [PATCH v9 27/27] qapi: Simplify visits of optional fields, Eric Blake, 2015/11/04
[Qemu-devel] [PATCH v9 23/27] qapi: Simplify visiting of alternate types, Eric Blake, 2015/11/04
Re: [Qemu-devel] [PATCH v9 00/27] alternate layout (post-introspection cleanups, subset C), Markus Armbruster, 2015/11/04
Re: [Qemu-devel] [PATCH v9 00/27] alternate layout (post-introspection cleanups, subset C), Markus Armbruster, 2015/11/05