[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-alpha: fix uninitialized variable
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [PATCH] target-alpha: fix uninitialized variable |
Date: |
Tue, 03 Nov 2015 15:01:21 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 |
22.10.2015 02:15, Richard Henderson wrote:
> On 10/19/2015 04:08 AM, Paolo Bonzini wrote:
>> I am not sure why the compiler does not catch it. There is no
>> semantic change since gen_excp returns EXIT_NORETURN, but the
>> old code is wrong.
>>
>> Reported by Coverity.
>>
>> Signed-off-by: Paolo Bonzini<address@hidden>
>> ---
>> target-alpha/translate.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Richard Henderson <address@hidden>
>
> I assume this will go in via trivial.
Richard, after your patch 522a0d4e3c0d397ffb45ec400d8cbd426dad9d17
"target-*: Advance pc after recognizing a breakpoint", this code
needs another review I think, as you modified the subsequent line ;)
Please take a look.
Thanks,
/mjt
- Re: [Qemu-devel] [PATCH] target-alpha: fix uninitialized variable,
Michael Tokarev <=