[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] trace: fix Makefile dependencies
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] trace: fix Makefile dependencies |
Date: |
Mon, 2 Nov 2015 13:24:00 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Oct 30, 2015 at 09:53:13AM +0000, Stefan Hajnoczi wrote:
> v2:
> * Use find(1) to catch all tracetool *.py files [LluĂs]
>
> Note: I used find -name instead of find -path for better POSIX compliance
>
> Issues with trace/Makefile.objs:
>
> 1. Generated code is not recreated when patches modify scripts/tracetool/*.py.
> Typically such patches also modify trace/*.[ch] and the result is build
> failures when new C code compiles against stale generated code.
>
> 2. The timestamp mechanism used to avoid unnecessary rebuilding is broken, it
> currently requires two make invocations for a full build.
>
> Stefan Hajnoczi (2):
> trace: fix make foo-timestamp rules
> trace: add make dependencies on tracetool source
>
> trace/Makefile.objs | 48 ++++++++++++++++++++++++++++--------------------
> 1 file changed, 28 insertions(+), 20 deletions(-)
>
> --
> 2.4.3
>
>
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 0/2] trace: fix Makefile dependencies,
Stefan Hajnoczi <=