[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/4] block: Add 'x-blockdev-del' QMP command
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/4] block: Add 'x-blockdev-del' QMP command |
Date: |
Sat, 31 Oct 2015 19:01:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 23.10.2015 14:03, Alberto Garcia wrote:
> This command is still experimental, hence the name.
>
> This is the companion to 'blockdev-add'. It allows deleting a
> BlockBackend with its associated BlockDriverState tree, or a
> BlockDriverState that is not attached to any backend.
>
> In either case, the command fails if the reference count is greater
> than 1 or the BlockDriverState has any parents.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> blockdev.c | 66
> ++++++++++++++++++++++++++++++++++++++++++++++++++++
> qapi/block-core.json | 32 +++++++++++++++++++++++--
> qmp-commands.hx | 46 ++++++++++++++++++++++++++++++++++--
> 3 files changed, 140 insertions(+), 4 deletions(-)
s/being used/in use/ might be better, and I don't think adding an
associated blockdev-add to the example in qmp-commands.hx would hurt
(stressing that they are intended to be paired; "virtio0" makes it look
like blockdev-del is for deleting auto-generated BBs, too (which may
work, but that doesn't seem to be its intended purpose)).
Anyway:
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature