Re: [Qemu-devel] [PATCH v6 14/33] pc-dimm: drop the prefix of pc-dimm

[Xiao Guangrong]

On 10/31/2015 12:10 AM, Vladimir Sementsov-Ogievskiy wrote:
> On 30.10.2015 08:56, Xiao Guangrong wrote:
> > This patch is generated by this script:
> >
> > find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \
> > | xargs sed -i "s/PC_DIMM/DIMM/g"
> >
> > find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \
> > | xargs sed -i "s/PCDIMM/DIMM/g"
> >
> > find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \
> > | xargs sed -i "s/pc_dimm/dimm/g"
> >
> > find ./ -name "trace-events" -type f | xargs sed -i "s/pc-dimm/dimm/g"
> >
> > It prepares the work which abstracts dimm device type for both pc-dimm and
> > nvdimm
> >
> > Signed-off-by: Xiao Guangrong <address@hidden>
> > ---
> >   hmp.c                           |   2 +-
> >   hw/acpi/ich9.c                  |   6 +-
> >   hw/acpi/memory_hotplug.c        |  16 ++---
> >   hw/acpi/piix4.c                 |   6 +-
> >   hw/i386/pc.c                    |  32 ++++-----
> >   hw/mem/pc-dimm.c                | 148 ++++++++++++++++++++--------------------
> >   hw/ppc/spapr.c                  |  18 ++---
> >   include/hw/mem/pc-dimm.h        |  62 ++++++++---------
> >   numa.c                          |   2 +-
> >   qapi-schema.json                |   8 +--
> >   qmp.c                           |   2 +-
> >   stubs/qmp_pc_dimm_device_list.c |   2 +-
> >   trace-events                    |   8 +--
> >   13 files changed, 156 insertions(+), 156 deletions(-)
>
>
> In the following patches, dimm is a parent for nv-dimm and pc-dimm, so dimm is 
> more abstract when
> nv-dimm and pc-dimm are more concrete. So for me it is strange, that all these 
> files, all old staff
> will use an abstract dimm. What the purpose of pc-dimm in this case (which 
> appeared in the following
> patches)?

The logic pc-dimm used can be completely shared by NVDIMM, so we abstracted 
'dimm' from pc-dimm,
and let the common code handle dimm instead of pc-dimm so that the common code 
will handle NVDIMM
automatically.

Actually, pc-dimm just inherit things from dimm, it does not have personal data.