[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] qemu-iotests: fix -valgrind option for c
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] qemu-iotests: fix -valgrind option for check |
Date: |
Fri, 30 Oct 2015 22:14:56 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 30.10.2015 20:25, Jeff Cody wrote:
> Commit 934659c switched the iotests to run qemu-io from a bash subshell,
> in order to catch segfaults. This method is incompatible with the
> current valgrind_qemu_io() bash function.
>
> Move the valgrind usage into the exec subshell in _qemu_io_wrapper(),
> while making sure the original return value is passed back to the
> caller.
>
> Update test output for tests 039, 061, and 137 as it looks for the
> specific subshell command when the process is terminated.
>
> Reported-by: Kevin Wolf <address@hidden>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> tests/qemu-iotests/039.out | 30 +++++++++++++++++++++++++-----
> tests/qemu-iotests/061.out | 12 ++++++++++--
> tests/qemu-iotests/137.out | 6 +++++-
> tests/qemu-iotests/common | 9 ++-------
> tests/qemu-iotests/common.config | 18 +++++++++++++++++-
> tests/qemu-iotests/common.rc | 10 ----------
> 6 files changed, 59 insertions(+), 26 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature