[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/16] vl.c: Reword -no-kvm-pit-reinjection d
From: |
Andrew Jones |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/16] vl.c: Reword -no-kvm-pit-reinjection deprecation warning |
Date: |
Fri, 30 Oct 2015 08:33:08 -0500 |
User-agent: |
Mutt/1.5.23.1 (2014-03-12) |
On Thu, Oct 29, 2015 at 06:10:17PM +0100, Markus Armbruster wrote:
> Eduardo Habkost <address@hidden> writes:
>
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> > vl.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/vl.c b/vl.c
> > index af8d09c..67147e0 100644
> > --- a/vl.c
> > +++ b/vl.c
> > @@ -3667,8 +3667,8 @@ int main(int argc, char **argv, char **envp)
> > { /* end of list */ }
> > };
> >
> > - error_report("warning: option deprecated, use "
> > - "lost_tick_policy property of kvm-pit
> > instead");
> > + error_report("warning: -no-kvm-pit-reinjection deprecated
> > by "
> > + "-global kvm-pit.lost_tick_policy=discard");
> > qdev_prop_register_global_list(kvm_pit_lost_tick_policy);
> > break;
> > }
>
> Repeating the option in the error message rarely improves the message,
> because error_report() already shows it. It's actually misleading when
> the option comes from a configuration file read with -readconfig.
>
> Fortunately, -readconfig doesn't support the option, so that's not an
> issue here.
>
> For the command line, the message changes from
>
> qemu-system-x86_64: -no-kvm-pit-reinjection: warning: option deprecated,
> use lost_tick_policy property of kvm-pit instead
>
> to
>
> qemu-system-x86_64: -no-kvm-pit-reinjection: warning:
> -no-kvm-pit-reinjection deprecated by -global kvm-pit.lost_tick_policy=discard
>
> Perhaps:
>
> qemu-system-x86_64: -no-kvm-pit-reinjection: warning: deprecated,
> replaced by -global kvm-pit.lost_tick_policy=discard
>
> Similar argument for PATCH 08.
>
Ah, I hadn't looked closely enough at error_report to know that the option
would be output already with my "ignoring" phrase suggestion. I definitely
agree that repeating it should be avoided.
"warning: deprecated, ignoring"
Thanks,
drew
- [Qemu-devel] [PATCH v2 02/16] vl.c: Use error_report() when reporting shutdown signal, (continued)
- [Qemu-devel] [PATCH v2 02/16] vl.c: Use error_report() when reporting shutdown signal, Eduardo Habkost, 2015/10/28
- [Qemu-devel] [PATCH v2 04/16] vl.c: Use "warning:" prefix consistently on warnings, Eduardo Habkost, 2015/10/28
- [Qemu-devel] [PATCH v2 06/16] vl.c: Use 'quotes' instead of `quotes' in messages, Eduardo Habkost, 2015/10/28
- [Qemu-devel] [PATCH v2 05/16] vl.c: Use "cannot" instead of "can not" in error messages, Eduardo Habkost, 2015/10/28
- [Qemu-devel] [PATCH v2 08/16] vl.c: Simplify "ignoring deprecated option" warnings, Eduardo Habkost, 2015/10/28
- [Qemu-devel] [PATCH v2 07/16] vl.c: Use "%s support disabled" error messages consistently, Eduardo Habkost, 2015/10/28
- [Qemu-devel] [PATCH v2 09/16] vl.c: Reword -no-kvm-pit-reinjection deprecation warning, Eduardo Habkost, 2015/10/28
- [Qemu-devel] [PATCH v2 10/16] vl.c: Convert error sentences to simpler phrases, Eduardo Habkost, 2015/10/28
- [Qemu-devel] [PATCH v2 11/16] vl.c: Remove unnecessary uppercase in error messages, Eduardo Habkost, 2015/10/28
- [Qemu-devel] [PATCH v2 12/16] vl.c: trivial: Don't wrap lines unnecessarily, Eduardo Habkost, 2015/10/28
- [Qemu-devel] [PATCH v2 14/16] vl.c: Simplify date format error message, Eduardo Habkost, 2015/10/28
- [Qemu-devel] [PATCH v2 13/16] vl.c: Reword -machine help error messages, Eduardo Habkost, 2015/10/28
- [Qemu-devel] [PATCH v2 15/16] vl.c: Use US spelling for "unrecognized", Eduardo Habkost, 2015/10/28
- [Qemu-devel] [PATCH v2 16/16] vl.c: Reword fw_cfg name prefix warning, Eduardo Habkost, 2015/10/28