[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] exec: silence hugetlbfs warning under qtest
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH] exec: silence hugetlbfs warning under qtest |
Date: |
Thu, 29 Oct 2015 11:10:14 +0200 |
On Tue, Oct 27, 2015 at 05:29:43PM +0100, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> vhost-user-test prints a warning. A test should not need to run on
> hugetlbfs, let's silence the warning under qtest. Unfortunately, the
> condition can't check on qtest_enabled() or qtest_driver() since they
> are initialized later.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
I guess we need a command line option to suppress the warning.
Seems a lot of work for very little benefit, but that's
the best I could come up with.
> ---
> exec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/exec.c b/exec.c
> index 8af2570..d9c231d 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1194,8 +1194,9 @@ static long gethugepagesize(const char *path, Error
> **errp)
> return 0;
> }
>
> - if (fs.f_type != HUGETLBFS_MAGIC)
> + if (fs.f_type != HUGETLBFS_MAGIC && !getenv("QTEST_QEMU_BINARY")) {
> fprintf(stderr, "Warning: path not on HugeTLBFS: %s\n", path);
> + }
>
> return fs.f_bsize;
> }
> --
> 2.4.3