[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9] block: Track discard requests
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH 3/9] block: Track discard requests |
Date: |
Thu, 29 Oct 2015 09:34:07 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, 10/28 10:54, Kevin Wolf wrote:
> > - return 0;
> > +out:
> > + tracked_request_end(&req);
> > + return ret;
> > }
>
> I would prefer an explicit ret = 0 before the out label because
> otherwise you're relying on the previous value that has been set
> somewhere in the loop. As far as I can tell, it's still correct, but it
> makes it needlessly hard to tell whether success is 0 or >= 0.
Good point, will fix.
Fam
- [Qemu-devel] [PATCH 0/9] block: Fixes for bdrv_drain, Fam Zheng, 2015/10/26
- [Qemu-devel] [PATCH 1/9] block: Add more types for tracked request, Fam Zheng, 2015/10/26
- [Qemu-devel] [PATCH 2/9] block: Track flush requests, Fam Zheng, 2015/10/26
- [Qemu-devel] [PATCH 3/9] block: Track discard requests, Fam Zheng, 2015/10/26
- [Qemu-devel] [PATCH 4/9] iscsi: Emulate commands in iscsi_aio_ioctl as iscsi_ioctl, Fam Zheng, 2015/10/26
- [Qemu-devel] [PATCH 5/9] block: Add ioctl parameter fields to BlockRequest, Fam Zheng, 2015/10/26
- [Qemu-devel] [PATCH 6/9] block: Emulate bdrv_ioctl with bdrv_aio_ioctl and track both, Fam Zheng, 2015/10/26
- [Qemu-devel] [PATCH 7/9] block: Drop BlockDriver.bdrv_ioctl, Fam Zheng, 2015/10/26
- [Qemu-devel] [PATCH 8/9] block: Introduce BlockDriver.bdrv_drain callback, Fam Zheng, 2015/10/26
- [Qemu-devel] [PATCH 9/9] qed: Implement .bdrv_drain, Fam Zheng, 2015/10/26