qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/6] e1000: Various fixes and registers' impl


From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH v2 0/6] e1000: Various fixes and registers' implementation
Date: Wed, 28 Oct 2015 13:41:20 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0


On 10/27/2015 09:20 PM, Leonid Bloch wrote:
> This series fixes issues with packet/octet counting in e1000's Statistic
> registers, fixes a bug in the packet address filtering procedure, and
> implements many MAC registers that were absent before, some Statistic
> counters among them. Additionally, several cosmetic changes are made.
>
> Differences from v1:
> --------------------
> * Wording of several commit messages corrected.
> * For trivially implemented Diagnostic registers, a debug message is
>   added on read/write attempts, alerting of incomplete implementation.
> * Following testing on a physical device, only the lower 16 bits can now
>   be read from AIT, and only the lower 4 - from FFMT*.
> * The grow_8reg_if_not_full function is rewritten.
> * inc_tx_bcast_or_mcast_count and increase_size_stats are now called
>   from within e1000_send_packet, to avoid code duplication.
>
> The majority of these changes result from Jason Wang's review - thank
> you, Jason!
>
> Leonid Bloch (6):
>   e1000: Cosmetic and alignment fixes
>   e1000: Trivial implementation of various MAC registers
>   e1000: Fixing the received/transmitted packets' counters
>   e1000: Fixing the received/transmitted octets' counters
>   e1000: Fixing the packet address filtering procedure
>   e1000: Implementing various counters
>
>  hw/net/e1000.c      | 352 
> +++++++++++++++++++++++++++++++++++++++-------------
>  hw/net/e1000_regs.h |   8 +-
>  2 files changed, 275 insertions(+), 85 deletions(-)
>

Applied in https://github.com/jasowang/qemu/commits/net

Thanks



reply via email to

[Prev in Thread] Current Thread [Next in Thread]