[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 3/4] ahci: Add allwinner AHCI
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [RFC 3/4] ahci: Add allwinner AHCI |
Date: |
Mon, 26 Oct 2015 08:48:59 -0700 |
On Tue, Oct 13, 2015 at 11:28 AM, Beniamino Galvani <address@hidden> wrote:
> On Sun, Oct 11, 2015 at 09:21:35AM -0700, Peter Crosthwaite wrote:
>> --- a/hw/ide/ahci.c
>> +++ b/hw/ide/ahci.c
>> @@ -1692,9 +1692,107 @@ static const TypeInfo sysbus_ahci_info = {
>> .class_init = sysbus_ahci_class_init,
>> };
>>
>> +#define ALLWINNER_AHCI_MMIO_OFF 0x80
>> +#define ALLWINNER_AHCI_MMIO_SIZE 0x80
>
> These are already defined in the header file.
>
Dropped.
>> +static const VMStateDescription vmstate_allwinner_ahci = {
>> + .name = "a10.pic",
>
> .name = "allwinner-ahci" ?
>
Fixed. I also tweaked the name of the memory region to use - instead
of _ to match this.
Thanks.
Regards,
Peter
> Beniamino
- [Qemu-devel] [RFC 0/4] AHCI patches + Allwinner SATA, Peter Crosthwaite, 2015/10/11
- [Qemu-devel] [RFC 3/4] ahci: Add allwinner AHCI, Peter Crosthwaite, 2015/10/11
- [Qemu-devel] [RFC 4/4] arm: allwinner-a10: Add SATA, Peter Crosthwaite, 2015/10/11
- Re: [Qemu-devel] [RFC 0/4] AHCI patches + Allwinner SATA, Beniamino Galvani, 2015/10/12
- [Qemu-devel] [RFC 2/4] ahci: split realize and init, Peter Crosthwaite, 2015/10/15
- [Qemu-devel] [RFC 1/4] ahci: Add some MMIO debug printfs, Peter Crosthwaite, 2015/10/15
- Re: [Qemu-devel] [RFC 0/4] AHCI patches + Allwinner SATA, John Snow, 2015/10/26