[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v5 02/12] nbd: Mark fd handlers cli
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v5 02/12] nbd: Mark fd handlers client type as "external" |
Date: |
Wed, 21 Oct 2015 11:21:45 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Oct 21, 2015 at 10:06:39AM +0800, Fam Zheng wrote:
> So we could distinguish it from internal used fds, thus avoid handling
> unwanted events in nested aio polls.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> nbd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/nbd.c b/nbd.c
> index fbc66be..dab1ebb 100644
> --- a/nbd.c
> +++ b/nbd.c
> @@ -1446,7 +1446,7 @@ static void nbd_set_handlers(NBDClient *client)
> {
> if (client->exp && client->exp->ctx) {
> aio_set_fd_handler(client->exp->ctx, client->sock,
> - false,
> + true,
> client->can_read ? nbd_read : NULL,
> client->send_coroutine ? nbd_restart_write : NULL,
> client);
> @@ -1457,7 +1457,7 @@ static void nbd_unset_handlers(NBDClient *client)
> {
> if (client->exp && client->exp->ctx) {
> aio_set_fd_handler(client->exp->ctx, client->sock,
> - false, NULL, NULL, NULL);
> + true, NULL, NULL, NULL);
> }
> }
>
> --
> 2.4.3
>
>
Reviewed-by: Jeff Cody <address@hidden>
- [Qemu-devel] [PATCH v5 00/12] block: Protect nested event loop with bdrv_drained_begin and bdrv_drained_end, Fam Zheng, 2015/10/20
- [Qemu-devel] [PATCH v5 02/12] nbd: Mark fd handlers client type as "external", Fam Zheng, 2015/10/20
- Re: [Qemu-devel] [Qemu-block] [PATCH v5 02/12] nbd: Mark fd handlers client type as "external",
Jeff Cody <=
- [Qemu-devel] [PATCH v5 03/12] dataplane: Mark host notifiers' client type as "external", Fam Zheng, 2015/10/20
- [Qemu-devel] [PATCH v5 01/12] aio: Add "is_external" flag for event handlers, Fam Zheng, 2015/10/20
- [Qemu-devel] [PATCH v5 04/12] aio: introduce aio_{disable, enable}_external, Fam Zheng, 2015/10/20
- [Qemu-devel] [PATCH v5 05/12] block: Introduce "drained begin/end" API, Fam Zheng, 2015/10/20