[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches |
Date: |
Wed, 21 Oct 2015 09:04:43 +0200 |
> On Tue, 20 Oct 2015 16:35:44 +0100
> Peter Maydell <address@hidden> wrote:
>
> > On 20 October 2015 at 16:00, Cornelia Huck <address@hidden> wrote:
> > > The following changes since commit
> > > ee9dfed242610ecb91418270fd46b875ed56e201:
> > >
> > > Merge remote-tracking branch
> > > 'remotes/kraxel/tags/pull-input-20151020-1' into staging (2015-10-20
> > > 12:56:45 +0100)
> > >
> > > are available in the git repository at:
> > >
> > > git://github.com/cohuck/qemu tags/s390x-20151020
> > >
> > > for you to fetch changes up to bde5d1bcb63973802c21183d730e0ea7c0ae227c:
> > >
> > > s390x/cmma: clean up cmma reset (2015-10-20 16:21:01 +0200)
> > >
> > > ----------------------------------------------------------------
> > > More s390x patches. The first ones are fixes: A regression, missed
> > > compat and a missed part of the SIMD support. The others contain
> > > optimizations and cleanup.
> > >
> > > ----------------------------------------------------------------
> >
> > Hi; I'm afraid this fails to build with clang:
> > /home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-virtio-ccw.c:38:12:
> > error: duplicate 'const' declaration specifier
> > [-Werror,-Wduplicate-decl-specifier]
> > const char const *reset_dev_types[] = {
> > ^
> >
> >
> >
> > Did you mean "const char * const" ? (I always have trouble with this
> > corner of C syntax...)
>
> Not only you...
>
> David, can you take a look at this?
Looks like I'm also having trouble with it ;) Guess I should start to also
compile with clang.
yes, "const char * const" should be the right thing ... if not simply "const
char *".
David
- [Qemu-devel] [PULL 0/9] Next set of s390x patches, Cornelia Huck, 2015/10/20
- [Qemu-devel] [PULL 6/9] s390x/ipl: we always have an ipl device, Cornelia Huck, 2015/10/20
- [Qemu-devel] [PULL 8/9] s390x: reset crypto only on clear reset and QEMU reset, Cornelia Huck, 2015/10/20
- [Qemu-devel] [PULL 3/9] s390x/kvm: Fix vector validity bit in device machine checks, Cornelia Huck, 2015/10/20
- [Qemu-devel] [PULL 1/9] util/qemu-config: fix missing machine command line options, Cornelia Huck, 2015/10/20
- [Qemu-devel] [PULL 2/9] s390x/virtio-ccw: fix 2.4 virtio compat, Cornelia Huck, 2015/10/20
- [Qemu-devel] [PULL 5/9] s390x: unify device reset during subsystem_reset(), Cornelia Huck, 2015/10/20
- [Qemu-devel] [PULL 4/9] s390x: flagify mcic values, Cornelia Huck, 2015/10/20
- Re: [Qemu-devel] [PULL 0/9] Next set of s390x patches, Peter Maydell, 2015/10/20
- [Qemu-devel] [PULL 7/9] s390x: machine reset function with new ipl cpu handling, Cornelia Huck, 2015/10/20
- [Qemu-devel] [PULL 9/9] s390x/cmma: clean up cmma reset, Cornelia Huck, 2015/10/20