[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENT
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function |
Date: |
Tue, 20 Oct 2015 19:05:56 +0300 |
On Tue, Oct 20, 2015 at 04:51:49PM +0100, Stefan Hajnoczi wrote:
> On Mon, Oct 19, 2015 at 08:54:14AM +0800, Xiao Guangrong wrote:
> > +exit:
> > + /* Write our output result to dsm memory. */
> > + ((dsm_out *)dsm_ram_addr)->len = out->len;
>
> Missing byteswap?
That's why I'd prefer no structures, using build_append_int_noprefix,
unless the structure is used outside ACPI as well.
> I thought you were going to remove this field because it wasn't needed
> by the guest.
- Re: [Qemu-devel] [PATCH v4 27/33] nvdimm acpi: save arg3 for NVDIMM device _DSM method, (continued)
[Qemu-devel] [PATCH v4 25/33] nvdimm acpi: init the address region used by DSM, Xiao Guangrong, 2015/10/18
[Qemu-devel] [PATCH v4 29/33] nvdimm acpi: support DSM_DEV_FUN_NAMESPACE_LABEL_SIZE function, Xiao Guangrong, 2015/10/18
[Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function, Xiao Guangrong, 2015/10/18
Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function, Stefan Hajnoczi, 2015/10/20
- Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function, Xiao Guangrong, 2015/10/20
- Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function, Xiao Guangrong, 2015/10/20
- Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function, Stefan Hajnoczi, 2015/10/21
- Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function, Xiao Guangrong, 2015/10/21
- Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function, Igor Mammedov, 2015/10/29
[Qemu-devel] [PATCH v4 30/33] nvdimm acpi: support DSM_DEV_FUN_GET_NAMESPACE_LABEL_DATA, Xiao Guangrong, 2015/10/18
[Qemu-devel] [PATCH v4 31/33] nvdimm acpi: support DSM_DEV_FUN_SET_NAMESPACE_LABEL_DATA, Xiao Guangrong, 2015/10/18
[Qemu-devel] [PATCH v4 33/33] nvdimm: add maintain info, Xiao Guangrong, 2015/10/18
[Qemu-devel] [PATCH v4 32/33] nvdimm: allow using whole backend memory as pmem, Xiao Guangrong, 2015/10/18