[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 2/5] qdev: add the @unplug_is_blocked handler
From: |
Greg Kurz |
Subject: |
[Qemu-devel] [PATCH v3 2/5] qdev: add the @unplug_is_blocked handler |
Date: |
Tue, 20 Oct 2015 11:16:53 +0200 |
User-agent: |
StGit/0.17.1-dirty |
This handler allows to ask a device instance if it can be hot-unplugged. It
is to be defined in device classes where hot-unpluggability depends on the
device state (for example, virtio-9p devices cannot be unplugged if the 9p
share is mounted in the guest).
Signed-off-by: Greg Kurz <address@hidden>
---
hw/core/qdev.c | 4 ++++
include/hw/qdev-core.h | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 4ab04aa31e78..b37a3801117a 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -287,6 +287,10 @@ void qdev_unplug(DeviceState *dev, Error **errp)
return;
}
+ if (dc->unplug_is_blocked && !dc->unplug_is_blocked(dev, errp)) {
+ return;
+ }
+
qdev_hot_removed = true;
hotplug_ctrl = qdev_get_hotplug_handler(dev);
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index 8057aedaa6c0..a65d2be6f39b 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -38,6 +38,7 @@ typedef void (*DeviceRealize)(DeviceState *dev, Error **errp);
typedef void (*DeviceUnrealize)(DeviceState *dev, Error **errp);
typedef void (*BusRealize)(BusState *bus, Error **errp);
typedef void (*BusUnrealize)(BusState *bus, Error **errp);
+typedef bool (*HotUnplugBlocked)(DeviceState *dev, Error **errp);
struct VMStateDescription;
@@ -48,6 +49,8 @@ struct VMStateDescription;
* property is changed to %true. The default invokes @init if not %NULL.
* @unrealize: Callback function invoked when the #DeviceState:realized
* property is changed to %false.
+ * @unplug_is_blocked: Callback function invoked by qdev_unplug(). Return
%false
+ * to block hotunplug.
* @init: Callback function invoked when the #DeviceState::realized property
* is changed to %true. Deprecated, new types inheriting directly from
* TYPE_DEVICE should use @realize instead, new leaf types should consult
@@ -133,6 +136,7 @@ typedef struct DeviceClass {
void (*reset)(DeviceState *dev);
DeviceRealize realize;
DeviceUnrealize unrealize;
+ HotUnplugBlocked unplug_is_blocked;
/* device state */
const struct VMStateDescription *vmsd;
- [Qemu-devel] [PATCH v3 0/5] virtio-9p: hotplug and migration support, Greg Kurz, 2015/10/20
- [Qemu-devel] [PATCH v3 2/5] qdev: add the @unplug_is_blocked handler,
Greg Kurz <=
- [Qemu-devel] [PATCH v3 1/5] virtio-9p-coth: fix init function, Greg Kurz, 2015/10/20
- [Qemu-devel] [PATCH v3 3/5] virtio-9p: block hot-unplug when device is active, Greg Kurz, 2015/10/20
- [Qemu-devel] [PATCH v3 4/5] virtio-9p: add unrealize handler, Greg Kurz, 2015/10/20
- [Qemu-devel] [PATCH v3 5/5] virtio-9p: add savem handlers, Greg Kurz, 2015/10/20
- Re: [Qemu-devel] [PATCH v3 0/5] virtio-9p: hotplug and migration support, Michael S. Tsirkin, 2015/10/20