[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 08/14] net: merge qemu_deliver_packet and qemu_de
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 08/14] net: merge qemu_deliver_packet and qemu_deliver_packet_iov |
Date: |
Mon, 19 Oct 2015 15:25:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/10/2015 10:17, Jason Wang wrote:
> static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov,
> - int iovcnt)
> + int iovcnt, unsigned flags)
> {
> - uint8_t buffer[NET_BUFSIZE];
> + uint8_t buf[NET_BUFSIZE];
> + uint8_t *buffer;
> size_t offset;
>
> - offset = iov_to_buf(iov, iovcnt, 0, buffer, sizeof(buffer));
> + if (iovcnt == 1) {
> + buffer = iov[0].iov_base;
> + offset = iov[0].iov_len;
> + } else {
> + buffer = buf;
> + offset = iov_to_buf(iov, iovcnt, 0, buffer, sizeof(buffer));
You want "buf, sizeof(buf)" here. sizeof(buffer) is the size of a
pointer, which is wrong.
Jason, can you please fix this?
Paolo
> + }
- [Qemu-devel] [PULL 07/14] netfilter: hook packets before net queue send, (continued)
- [Qemu-devel] [PULL 07/14] netfilter: hook packets before net queue send, Jason Wang, 2015/10/12
- [Qemu-devel] [PULL 09/14] net/queue: introduce NetQueueDeliverFunc, Jason Wang, 2015/10/12
- [Qemu-devel] [PULL 10/14] netfilter: add an API to pass the packet to next filter, Jason Wang, 2015/10/12
- [Qemu-devel] [PULL 13/14] netfilter: add a netbuffer filter, Jason Wang, 2015/10/12
- [Qemu-devel] [PULL 14/14] tests: add test cases for netfilter object, Jason Wang, 2015/10/12
- Re: [Qemu-devel] [PULL 00/14] Net patches, Peter Maydell, 2015/10/12
- [Qemu-devel] [PULL 02/14] vmxnet3: Support reading IMR registers on bar0, Jason Wang, 2015/10/15
- [Qemu-devel] [PULL 04/14] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command, Jason Wang, 2015/10/15
- [Qemu-devel] [PULL 06/14] init/cleanup of netfilter object, Jason Wang, 2015/10/15
- [Qemu-devel] [PULL 08/14] net: merge qemu_deliver_packet and qemu_deliver_packet_iov, Jason Wang, 2015/10/15
- Re: [Qemu-devel] [PULL 08/14] net: merge qemu_deliver_packet and qemu_deliver_packet_iov,
Paolo Bonzini <=
- [Qemu-devel] [PULL 05/14] vl.c: init delayed object after net_init_clients, Jason Wang, 2015/10/15
- [Qemu-devel] [PULL 12/14] net/queue: export qemu_net_queue_append_iov, Jason Wang, 2015/10/15
- [Qemu-devel] [PULL 11/14] netfilter: print filter info associate with the netdev, Jason Wang, 2015/10/15