[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/3] ui/curses: Fix monitor color with -curses wh
From: |
OGAWA Hirofumi |
Subject: |
[Qemu-devel] [PATCH v2 1/3] ui/curses: Fix monitor color with -curses when 256 colors |
Date: |
Mon, 19 Oct 2015 21:23:10 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
If TERM=xterm-256color, COLOR_PAIRS==256 and monitor passes chtype
like 0x74xx. Then, the code uses uninitialized color pair. As result,
monitor uses black for both of fg and bg color, i.e. terminal is
filled by black.
To fix, this initialize above than 64 with default color (fg=white,bg=black).
FIXME: on 256 color, curses may be possible better vga color emulation.
Signed-off-by: OGAWA Hirofumi <address@hidden>
---
ui/curses.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff -puN ui/curses.c~support-curses-256color ui/curses.c
--- qemu/ui/curses.c~support-curses-256color 2015-10-14 20:12:06.311051365
+0900
+++ qemu-hirofumi/ui/curses.c 2015-10-19 21:16:24.595994457 +0900
@@ -341,8 +341,13 @@ static void curses_setup(void)
nodelay(stdscr, TRUE); nonl(); keypad(stdscr, TRUE);
start_color(); raw(); scrollok(stdscr, FALSE);
- for (i = 0; i < 64; i ++)
+ for (i = 0; i < 64; i++) {
init_pair(i, colour_default[i & 7], colour_default[i >> 3]);
+ }
+ /* Set default color for more than 64. (monitor uses 0x74xx for example) */
+ for (i = 64; i < COLOR_PAIRS; i++) {
+ init_pair(i, COLOR_WHITE, COLOR_BLACK);
+ }
}
static void curses_keyboard_setup(void)
_
- [Qemu-devel] [PATCH v2 1/3] ui/curses: Fix monitor color with -curses when 256 colors,
OGAWA Hirofumi <=