[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] spice: Allow to set password even if disable
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v3] spice: Allow to set password even if disable-ticketing was used |
Date: |
Tue, 13 Oct 2015 09:58:25 +0200 |
Hi,
> > If there is an actual use case where switching authentication methods at
> > runtime is needed we can discuss that. But we'll be doing that as
> > explicit monitor command, not as side-effect of something else.
>
> Yeah, I'm not saying this patch is a good idea. However, there was a
> silent change (by reading the commit log which introduced it, this
> change is not mentioned at all, so may have been unintentional)
Well, sort of. The check was mainly added to avoid set_ticket being
called with sasl auth being active. And as setting the ticket only
makes sense with spice auth being active (not knowing set_ticket can
switch auth mode) the check added verifies we are in spice auth mode.
> in
> behaviour in QEMU, and this change causes breakage in existing apps
> using QEMU.
Undocumented behavior.
> This patch only attempts to fix this regression, I'm not
> saying one behaviour or the other is better.
Fair enough. I still prefer to keep the current behavior.
cheers,
Gerd