Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit

[KY Srinivasan]

> -----Original Message-----
> From: Denis V. Lunev [mailto:address@hidden
> Sent: Monday, October 12, 2015 6:46 AM
> To: Eric Blake <address@hidden>
> Cc: Gleb Natapov <address@hidden>; address@hidden;
> address@hidden; address@hidden; Paolo
> Bonzini <address@hidden>; Andrey Smetanin
> <address@hidden>; Vitaly Kuznetsov <address@hidden>; KY
> Srinivasan <address@hidden>
> Subject: Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit
> 
> On 10/12/2015 04:42 PM, Eric Blake wrote:
> > On 10/09/2015 07:39 AM, Denis V. Lunev wrote:
> >> From: Andrey Smetanin <address@hidden>
> >>
> >> A new vcpu exit is introduced to notify the userspace of the
> >> changes in Hyper-V synic configuraion triggered by guest writing to the
> > s/configuraion/configuration/
> > Is 'synic' intended?  Is it short for something (if so, spelling it out
> > may help)?
> >
> >
> >> +++ b/Documentation/virtual/kvm/api.txt
> >> @@ -3331,6 +3331,12 @@ the userspace IOAPIC should process the EOI
> and retrigger the interrupt if
> >>   it is still asserted.  Vector is the LAPIC interrupt vector for which the
> >>   EOI was received.
> >>
> >> +          /* KVM_EXIT_HYPERV */
> >> +                struct kvm_hyperv_exit hyperv;
> >> +Indicates that the VCPU's exits into userspace to process some tasks
> > s/VCPU's/VCPU/
> >
> >> +related with Hyper-V emulation. Currently used to synchronize modified
> >> +Hyper-V synic state with userspace.
> > Again, is 'synic' intended?  Hmm, I see it throughout the patch, so it
> > looks intentional, but I keep trying to read it as a typo for 'sync'.
> >
> this is not a typo :)

Yes; the Hyper-V public functional spec has chosen this name;
it stands for Synthetic Interrupt Controller.

K. Y