[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED fu
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function |
Date: |
Thu, 15 Oct 2015 17:01:43 +0200 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Oct 14, 2015 at 10:52:15PM +0800, Xiao Guangrong wrote:
> On 10/14/2015 05:41 PM, Stefan Hajnoczi wrote:
> >On Sun, Oct 11, 2015 at 11:52:59AM +0800, Xiao Guangrong wrote:
> >>+ out->len = sizeof(out->status);
> >
> >out->len is uint16_t, it needs cpu_to_le16(). There may be other
> >instances in this patch series.
> >
>
> out->len is internally used only which is invisible to guest OS, i,e,
> we write this value and read this value by ourself. I think it is
> okay.
'out' points to guest memory. Guest memory is untrusted so QEMU cannot
stash values there - an evil guest could modify them.
Please put the len variable on the QEMU stack or heap where the guest
cannot access it.
- [Qemu-devel] [PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method, (continued)
- [Qemu-devel] [PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method, Xiao Guangrong, 2015/10/10
- [Qemu-devel] [PATCH v3 20/32] dimm: introduce realize callback, Xiao Guangrong, 2015/10/10
- [Qemu-devel] [PATCH v3 28/32] nvdimm: support DSM_CMD_NAMESPACE_LABEL_SIZE function, Xiao Guangrong, 2015/10/10
- [Qemu-devel] [PATCH v3 05/32] acpi: add aml_concatenate, Xiao Guangrong, 2015/10/10
- [Qemu-devel] [PATCH v3 06/32] acpi: add aml_object_type, Xiao Guangrong, 2015/10/10
- [Qemu-devel] [PATCH v3 09/32] exec: allow file_ram_alloc to work on file, Xiao Guangrong, 2015/10/10
- [Qemu-devel] [PATCH v3 19/32] dimm: keep the state of the whole backend memory, Xiao Guangrong, 2015/10/10
- [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function, Xiao Guangrong, 2015/10/10
- Re: [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function, Stefan Hajnoczi, 2015/10/14
- Re: [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function, Stefan Hajnoczi, 2015/10/15
- Re: [Qemu-devel] [PATCH v3 27/32] nvdimm: support DSM_CMD_IMPLEMENTED function, Xiao Guangrong, 2015/10/15
[Qemu-devel] [PATCH v3 30/32] nvdimm: support DSM_CMD_SET_NAMESPACE_LABEL_DATA, Xiao Guangrong, 2015/10/10
[Qemu-devel] [PATCH v3 31/32] nvdimm: allow using whole backend memory as pmem, Xiao Guangrong, 2015/10/10
[Qemu-devel] [PATCH v3 01/32] acpi: add aml_derefof, Xiao Guangrong, 2015/10/10