[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] qbool: Make conversion from QObject * accep
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/6] qbool: Make conversion from QObject * accept null |
Date: |
Thu, 15 Oct 2015 09:27:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/15/2015 08:15 AM, Markus Armbruster wrote:
> qobject_to_qbool() crashes on null, which is a trap for the unwary.
> Return null instead, and simplify a few callers.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qapi/qmp-input-visitor.c | 6 +++---
> qobject/qbool.c | 4 ++--
> qobject/qdict.c | 11 +++--------
> 3 files changed, 8 insertions(+), 13 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/6] qobject: Make conversion from QObject * accept null, Markus Armbruster, 2015/10/15
- [Qemu-devel] [PATCH 1/6] qobject: Drop QObject_HEAD, Markus Armbruster, 2015/10/15
- [Qemu-devel] [PATCH 2/6] qbool: Make conversion from QObject * accept null, Markus Armbruster, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/6] qbool: Make conversion from QObject * accept null,
Eric Blake <=
- [Qemu-devel] [PATCH 5/6] qlist: Make conversion from QObject * accept null, Markus Armbruster, 2015/10/15
- [Qemu-devel] [PATCH 6/6] qstring: Make conversion from QObject * accept null, Markus Armbruster, 2015/10/15
- Re: [Qemu-devel] [PATCH 0/6] qobject: Make conversion from QObject * accept null, Luiz Capitulino, 2015/10/15
- [Qemu-devel] [PATCH 3/6] qdict: Make conversion from QObject * accept null, Markus Armbruster, 2015/10/15
- [Qemu-devel] [PATCH 4/6] qfloat qint: Make conversion from QObject * accept null, Markus Armbruster, 2015/10/15