[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt contro
From: |
Roman Kagan |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller |
Date: |
Fri, 9 Oct 2015 18:53:09 +0300 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Oct 09, 2015 at 04:42:33PM +0200, Paolo Bonzini wrote:
> You need to add SYNIC vectors to the EOI exit bitmap, so that APICv
> (Xeon E5 or higher, Ivy Bridge or newer) is handled correctly. You also
> need to check the auto EOI exit bitmap in __apic_accept_irq, and avoid
> going through kvm_x86_ops->deliver_posted_interrupt for auto EOI
> vectors. Something like
>
> if (kvm_x86_ops->deliver_posted_interrupt &&
> !test_bit(...))
>
> in place of the existing "if (kvm_x86_ops->deliver_posted_interrupt)".
Indeed, missed that path, thanks!
> I really don't like this auto-EOI extension, but I guess that's the
> spec. :( If it wasn't for it, you could do everything very easily in
> userspace using Google's proposed MSR exit.
I guess you're right. We'd probably have to (ab)use MSI for SINT
delivery, though. Anyway the need to implement auto-EOI rules that out.
Thanks for the quick review, we'll try to address your comments in the
next round.
Roman.
- [Qemu-devel] [PATCH 0/2] Hyper-V synthetic interrupt controller, Denis V. Lunev, 2015/10/10
- [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller, Denis V. Lunev, 2015/10/09
- Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller, Paolo Bonzini, 2015/10/09
- Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller, Christian Borntraeger, 2015/10/15
- Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller, Cornelia Huck, 2015/10/12
- Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller, Paolo Bonzini, 2015/10/12
- Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V synthetic interrupt controller, Roman Kagan, 2015/10/12
[Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit, Denis V. Lunev, 2015/10/09
Re: [Qemu-devel] [PATCH 2/2] kvm/x86: Hyper-V kvm exit, Eric Blake, 2015/10/12