[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 12/25] vhost: use a function for each call
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL 12/25] vhost: use a function for each call |
Date: |
Fri, 9 Oct 2015 10:37:41 +0300 |
On Fri, Oct 09, 2015 at 08:40:27AM +0200, Thibaut Collet wrote:
> Hi Michael,
>
> this patch is not correct. If we apply QEMU enters in a dead lock if
> we have several queue pairs for virttio/vhost and vhost backend
> crashes during the initialisation sequence
> I have sent some comments yesterday to Marc to correct theses issues.
> The attached fixup solves the issues (already sent to Marc Andre on
> QEMU mailing list):
> - The two first corrections solve the vhost backend crashes (the
> message id used for some messages are the kernel IOCTL and not the
> VHOST_USER id)
> - the third patchs solves the QEMU dead lock in case of multiqueue
> (VHOST_USER_GET_QUEUE_NUM is a one time message. This message is sent
> through the new vhost_user_get_u64 function but except for the first
> queue a blocking read is sent whereas no write has been sent before
> that causes the lock)
>
> If you (and Marc Andre) agree this correction could you update this
> patch with the fixup and resend the pull request ?
>
> Thanks
>
> Best regards.
>
> Thibaut.
I dropped this and dependent patches from the tree for now.
Thanks!
--
MST
- [Qemu-devel] [PULL 24/25] vhost-user-test: check ownership during migration, (continued)
- [Qemu-devel] [PULL 24/25] vhost-user-test: check ownership during migration, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 22/25] vhost-user-test: learn to tweak various qemu arguments, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 25/25] intel_iommu: Add support for translation for devices behind bridges, Michael S. Tsirkin, 2015/10/08
- [Qemu-devel] [PULL 11/25] vhost-user: add a migration blocker, Michael S. Tsirkin, 2015/10/09
- [Qemu-devel] [PULL 08/25] vhost-user: add vhost_user_requires_shm_log(), Michael S. Tsirkin, 2015/10/09
- [Qemu-devel] [PULL 23/25] vhost-user-test: add live-migration test, Michael S. Tsirkin, 2015/10/09
- [Qemu-devel] [PULL 18/25] vhost: add migration block if memfd failed, Michael S. Tsirkin, 2015/10/09
- [Qemu-devel] [PULL 02/25] linux-headers: add unistd.h, Michael S. Tsirkin, 2015/10/09
- [Qemu-devel] [PULL 12/25] vhost: use a function for each call, Michael S. Tsirkin, 2015/10/09
- [Qemu-devel] [PULL 16/25] vhost user: add rarp sending after live migration for legacy guest, Michael S. Tsirkin, 2015/10/09
- [Qemu-devel] [PULL 17/25] vhost-user: use an enum helper for features mask, Michael S. Tsirkin, 2015/10/09
- [Qemu-devel] [PULL 19/25] vhost-user-test: move wait_for_fds() out, Michael S. Tsirkin, 2015/10/09
- Re: [Qemu-devel] [PULL 00/25] virtio,pc features, fixes, Peter Maydell, 2015/10/10