[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qmp-commands.hx: Update the supported 'transact
From: |
Kashyap Chamarthy |
Subject: |
Re: [Qemu-devel] [PATCH] qmp-commands.hx: Update the supported 'transaction' operations |
Date: |
Fri, 2 Oct 2015 14:51:43 +0200 |
User-agent: |
Mutt/1.5.23.1 (2014-03-12) |
On Fri, Oct 02, 2015 at 06:40:28AM -0600, Eric Blake wrote:
> On 10/02/2015 06:12 AM, Kashyap Chamarthy wrote:
> > Although the canonical source of reference for QMP commands is
> > qapi-schema.json, for consistency's sake, update qmp-commands.hx to
> > state the list of supported transactionable operations, namely:
> >
> > drive-backup
> > blockdev-backup
> > blockdev-snapshot-internal-sync
> > abort
> > block-dirty-bitmap-add
> > block-dirty-bitmap-clear
> >
> > Also update the possible values for the "type" action array.
> >
> > Signed-off-by: Kashyap Chamarthy <address@hidden>
> > Reviewed-by: Eric Blake <address@hidden>
>
> Significant enough changes that I would have dropped R-b before posting
> to ensure it gets looked at.
Yes, I was wary of this and thought I included a blurb "Removing Eric's
R-b as this change involves more edits." My bad, seems to have missed
it while message composition. And, your reminder doesn't hurt.
> But fortunately, you did a good job, so you can still keep my R-b.
Thanks.
--
/kashyap