[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/7] memory: Allow replay of IOMMU mapping notif
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 5/7] memory: Allow replay of IOMMU mapping notifications |
Date: |
Wed, 30 Sep 2015 12:15:43 +1000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Sep 29, 2015 at 09:15:58AM +0200, Paolo Bonzini wrote:
>
>
> On 29/09/2015 05:30, David Gibson wrote:
> >> Maybe... The only issue is the "granularity" argument, which is
> >> not in memory_region_register_iommu_notifier. That makes me
> >> wonder if the replay and registration make sense as separate
> >> operations.
> >>
> >> What about adding a new function memory_region_iommu_replay and
> >> separate the two phases?
> >
> > Hm.. I'm not sure I see much advantage to separating the phases.
>
> It's just that it's (IMO) the clearest API. It shows how the
> granularity is only used for replay.
>
> > But I don't particularly object to the idea either. So, I think
> it's your
> > call.
>
> Yes, let's separate it.
Ok, I've done that, and sent a hopefull final respin of the series.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpUTrUoy2ZSM.pgp
Description: PGP signature