[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 10/12] qapi: Correct error for union branch '
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 10/12] qapi: Correct error for union branch 'kind' clash |
Date: |
Sat, 3 Oct 2015 11:56:13 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 10/01/2015 10:31 PM, Eric Blake wrote:
> The error message when a simple union or alternate contains a
> branch named 'kind' is ugly, because it is tied to the Schema
> member named 'type'. A future patch will fix the generated C
> to match QMP, but until that point, we can hack things with
> a temporary subclass to make the error message reflect the
> actually collision.
I found a cleaner way to do this, and will be dropping this patch,
except for the testsuite improvements which I will be merging into 9/12.
>
> Rename alternate-clash to alternate-clash-members, and add a
> new test alternate-clash-type. While similar to the earlier
> addition of union-clash-type, we have one major difference: a
> future patch will be simplifying alternates to not need an
> implict AlternateKind enum, but we still need to detect the
> collision with the resulting C 'qtype_code type;' tag.
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v6 05/12] qapi: Track location that created an implicit type, (continued)
[Qemu-devel] [PATCH v6 08/12] qapi: Defer duplicate member checks to schema check(), Eric Blake, 2015/10/08
[Qemu-devel] [PATCH v6 11/12] qapi: Detect base class loops, Eric Blake, 2015/10/08
[Qemu-devel] [PATCH v6 12/12] RFC: qapi: Hide _info member, Eric Blake, 2015/10/08
[Qemu-devel] [PATCH v6 10/12] qapi: Correct error for union branch 'kind' clash, Eric Blake, 2015/10/08
- Re: [Qemu-devel] [PATCH v6 10/12] qapi: Correct error for union branch 'kind' clash,
Eric Blake <=
[Qemu-devel] [PATCH v6 09/12] qapi: Defer duplicate enum value checks to schema check(), Eric Blake, 2015/10/08
[Qemu-devel] [PATCH v6 01/12] qapi: Use predicate callback to determine visit filtering, Eric Blake, 2015/10/08
[Qemu-devel] [PATCH v6 03/12] qapi: Lazy creation of array types, Eric Blake, 2015/10/08