Re: [Qemu-devel] [PATCH v7 03/24] util: add linux-only memfd fallback

[Michael S. Tsirkin]

On Fri, Oct 02, 2015 at 09:56:17AM -0400, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > On Thu, Oct 01, 2015 at 07:23:47PM +0200, address@hidden wrote:
> > > diff --git a/util/Makefile.objs b/util/Makefile.objs
> > > index 372e037..9e05861 100644
> > > --- a/util/Makefile.objs
> > > +++ b/util/Makefile.objs
> > > @@ -1,13 +1,18 @@
> > >  util-obj-y = osdep.o cutils.o unicode.o qemu-timer-common.o
> > >  util-obj-$(CONFIG_WIN32) += oslib-win32.o qemu-thread-win32.o
> > >  event_notifier-win32.o
> > > -util-obj-$(CONFIG_POSIX) += oslib-posix.o qemu-thread-posix.o
> > > event_notifier-posix.o qemu-openpty.o mmap-alloc.o
> > > +util-obj-$(CONFIG_POSIX) += oslib-posix.o
> > > +util-obj-$(CONFIG_POSIX) += qemu-thread-posix.o
> > > +util-obj-$(CONFIG_POSIX) += event_notifier-posix.o
> > > +util-obj-$(CONFIG_POSIX) += qemu-openpty.o
> > > +util-obj-$(CONFIG_POSIX) += compatfd.o
> > > +util-obj-$(CONFIG_POSIX) += mmap-alloc.o
> > > +util-obj-$(CONFIG_POSIX) += memfd.o
> > >  util-obj-y += envlist.o path.o module.o
> > >  util-obj-$(call lnot,$(CONFIG_INT128)) += host-utils.o
> > >  util-obj-y += bitmap.o bitops.o hbitmap.o
> > >  util-obj-y += fifo8.o
> > >  util-obj-y += acl.o
> > >  util-obj-y += error.o qemu-error.o
> > > -util-obj-$(CONFIG_POSIX) += compatfd.o
> > >  util-obj-y += id.o
> > >  util-obj-y += iov.o qemu-config.o qemu-sockets.o uri.o notify.o
> > >  util-obj-y += qemu-option.o qemu-progress.o
> > 
> > Will be easier to apply if this refactoring is a separate patch.
> > 
> > 
> Sure, would you mind to do it if you pick the series, or does this deserve 
> another update?

Pls send an update.  I just posted a pull request, so we have some time
to get it right until I send the next one.

-- 
MST