Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline

[Eric Blake]

On 09/28/2015 07:30 AM, Laszlo Ersek wrote:

>>  
>> +Small enough items may be provided directly as strings on the command
>> +line, using the syntax:
>> +
>> +    -fw_cfg [name=]<item_name>,content=<string>
>> +
> 
> Please consider spelling out that these blobs will NOT be NUL-terminated
> when viewed on the guest. (It kinda follows from all the other fw_cfg
> things, but once we leave host-side files for qemu command line strings,
> it might become non-obvious to users.)

Or else GUARANTEE that it will be NUL-terminated (and the only way to
get blobs that are not NUL terminated is to use files rather than content=).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature