|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 3/3] block: mirror - zero unallocated target sectors when zero init not present |
Date: | Mon, 28 Sep 2015 16:13:35 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 28/09/2015 05:29, Jeff Cody wrote: > This only occurs under two conditions: > > 1. 'mode' != "existing" > 2. bdrv_has_zero_init(target) == NULL > I'm not sure if mode != "existing" actually matters. I think what actually matters is sync == "full". The reasons are: 1) with sync != "full", unallocated target sectors should remain unallocated on the destination because they are supposed to point to the backing file. 2) even with mode == "existing" you expect the data to be consistent at the end of the mirroring Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |