[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/arm/digic: Fix memory leak reported by Cover
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH] hw/arm/digic: Fix memory leak reported by Coverity |
Date: |
Fri, 25 Sep 2015 21:55:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 |
Am 14.03.2015 um 11:19 schrieb Stefan Weil:
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> hw/arm/digic_boards.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c
> index 7114c36..ad70f7b 100644
> --- a/hw/arm/digic_boards.c
> +++ b/hw/arm/digic_boards.c
> @@ -109,6 +109,7 @@ static void digic_load_rom(DigicBoardState *s, hwaddr
> addr,
> }
>
> rom_size = load_image_targphys(fn, addr, max_size);
> + g_free(fn);
> if (rom_size < 0 || rom_size > max_size) {
> error_report("Couldn't load rom image '%s'.", filename);
> exit(1);
>
Ping? Maybe this old patch can be applied to qemu-trivial.
fn = qemu_find_file() allocates memory, so g_free is needed.
Regards
Stefan
- Re: [Qemu-devel] [PATCH] hw/arm/digic: Fix memory leak reported by Coverity,
Stefan Weil <=