Re: [Qemu-devel] [PATCH 11/36] build-sys: generate QAPI doc based on json

[Eric Blake]

On 09/25/2015 08:03 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
> 
> Learn to generate info/html/pdf/man documentation for QEMU and agent QMP
> APIs.
> 
> This allows to provide missing agent documentation, and should help

"allows to" is not idiomatic English (it is missing a subject of who is
being allowed).  Better would be either:

This allows us to provide missing agent documentation,
This provides missing agent documentation,

although I'd lean to the shorter form.

> getting rid of the duplicate documentation in qmp-commands.hx.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  Makefile | 36 ++++++++++++++++++++++++++++++------
>  1 file changed, 30 insertions(+), 6 deletions(-)
> @@ -363,7 +364,7 @@ distclean: clean
>       rm -f qemu-doc.vr
>       rm -f config.log
>       rm -f linux-headers/asm
> -     rm -f qemu-tech.info qemu-tech.aux qemu-tech.cp qemu-tech.dvi 
> qemu-tech.fn qemu-tech.info qemu-tech.ky qemu-tech.log qemu-tech.pdf 
> qemu-tech.pg qemu-tech.toc qemu-tech.tp qemu-tech.vr
> +     rm -f qemu-tech.info qemu-tech.aux qemu-tech.cp qemu-tech.dvi 
> qemu-tech.fn qemu-tech.info qemu-tech..ky qemu-tech.log qemu-tech.pdf 
> qemu-tech.pg qemu-tech.toc qemu-tech.tp qemu-tech.vr qemu-qapi.info 
> qemu-qapi.aux qemu-qapi.cp qemu-qapi.dvi qemu-qapi.fn qemu-qapi.info 
> qemu-qapi..ky qemu-qapi.log qemu-qapi.pdf qemu-qapi.pg qemu-qapi.toc 
> qemu-qapi.tp qemu-qapi.vr qemu-ga-qapi.info qemu-ga-qapi.aux qemu-ga-qapi.cp 
> qemu-ga-qapi.dvi qemu-ga-qapi.fn qemu-ga-qapi.info qemu-ga-qapi..ky 
> qemu-ga-qapi.log qemu-ga-qapi.pdf qemu-ga-qapi.pg qemu-ga-qapi.toc 
> qemu-ga-qapi.tp qemu-ga-qapi.vr

This line is now way long; can we use \ continuation to split it into
something easier to manage?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature