[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH 09/10] vnc: kill jobs queue buffer
From: |
Peter Lieven |
Subject: |
Re: [Qemu-devel] [RfC PATCH 09/10] vnc: kill jobs queue buffer |
Date: |
Fri, 25 Sep 2015 11:57:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
Am 24.09.2015 um 10:42 schrieb Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> ui/vnc-jobs.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
> index 7a234da..50e6b37 100644
> --- a/ui/vnc-jobs.c
> +++ b/ui/vnc-jobs.c
> @@ -54,7 +54,6 @@ struct VncJobQueue {
> QemuCond cond;
> QemuMutex mutex;
> QemuThread thread;
> - QIOBuffer buffer;
> bool exit;
> QTAILQ_HEAD(, VncJob) jobs;
> };
> @@ -193,7 +192,6 @@ static void vnc_async_encoding_start(VncState *orig,
> VncState *local)
> local->zlib = orig->zlib;
> local->hextile = orig->hextile;
> local->zrle = orig->zrle;
> - local->output = queue->buffer;
> local->csock = -1; /* Don't do any network work on this thread */
>
> qio_buffer_reset(&local->output);
> @@ -206,8 +204,6 @@ static void vnc_async_encoding_end(VncState *orig,
> VncState *local)
> orig->hextile = local->hextile;
> orig->zrle = local->zrle;
> orig->lossy_rect = local->lossy_rect;
> -
> - queue->buffer = local->output;
> }
>
> static int vnc_worker_thread_loop(VncJobQueue *queue)
> @@ -303,7 +299,6 @@ static VncJobQueue *vnc_queue_init(void)
>
> qemu_cond_init(&queue->cond);
> qemu_mutex_init(&queue->mutex);
> - qio_buffer_init(&queue->buffer, "vnc-job-queue");
> QTAILQ_INIT(&queue->jobs);
> return queue;
> }
> @@ -312,7 +307,6 @@ static void vnc_queue_clear(VncJobQueue *q)
> {
> qemu_cond_destroy(&queue->cond);
> qemu_mutex_destroy(&queue->mutex);
> - qio_buffer_free(&queue->buffer);
> g_free(q);
> queue = NULL; /* Unset global queue */
> }
Reviewed-by: Peter Lieven <address@hidden>
- [Qemu-devel] [RfC PATCH 00/10] vnc buffer handling, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 03/10] vnc: make the Buffer capacity increase in powers of two, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 04/10] io: add qio_buffer_init, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 01/10] io/ makefile fluff, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 06/10] io: add qio_buffer_move, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 09/10] vnc: kill jobs queue buffer, Gerd Hoffmann, 2015/09/24
- Re: [Qemu-devel] [RfC PATCH 09/10] vnc: kill jobs queue buffer,
Peter Lieven <=
- [Qemu-devel] [RfC PATCH 07/10] io: add qio_buffer tracing, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 08/10] name vnc buffers, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 05/10] io: add qio_buffer_move_empty, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 10/10] vnc-jobs: move buffer reset, use new buffer move, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [RfC PATCH 02/10] io: pull Buffer code out of VNC module, Gerd Hoffmann, 2015/09/24