[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] target-i386: get/put MSR_TSC_AUX across res
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] target-i386: get/put MSR_TSC_AUX across reset and migration |
|
Date: |
Thu, 24 Sep 2015 11:50:44 -0300 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Sep 23, 2015 at 09:47:43AM +0200, Paolo Bonzini wrote:
>
>
> On 23/09/2015 08:27, Amit Shah wrote:
> > There's one report of migration breaking due to missing MSR_TSC_AUX
> > save/restore. Fix this by adding a new subsection that saves the state
> > of this MSR.
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=1261797
>
> It turns out that the MSR is already saved/restored into the migration
> stream! However, the commit that introduced RDTSCP support (commit
> 1b05007, "target-i386: add RDTSCP support", 2009-09-19) was written for
> TCG, and we ended up forgetting to fish the value out of KVM and send it
> back in.
>
> The KVM bits are okay. Eduardo, can you undo the machine.c hunk or
> should Amit send v2?
I can remove the machine.c hunk manually when applying. Thanks!
--
Eduardo