[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] mingw: fix build on Fedora 22
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] mingw: fix build on Fedora 22 |
Date: |
Tue, 22 Sep 2015 15:14:12 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Sep 22, 2015 at 05:08:44PM +0300, Michael S. Tsirkin wrote:
> On Tue, Sep 22, 2015 at 02:48:04PM +0100, Daniel P. Berrange wrote:
> >
> > I don't think this is right. There are three possibilities
> > with mingw
> >
> > - No gmtime_r at all - need replacement
> > - gmtime_r defined as a macro - need replacement
> > - gmtime_r defined as a function - nothing needed
> >
> > With this change of yours, if gmtime_r is defined as a macro
> > QEMU will provide its own replacement. If gmtime_r is not
> > defined at all, then QEMU doesn't provide its replacement
> > which is wrong. I believe the change I previously proposed
> > works in all three cases
> >
> > https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01926.html
> >
> Good point.
> Can you bounce me your patch pls?
I just sent it as a REPOST, with everyone on this thread CC'd.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|