Re: [Qemu-devel] [PATCH v4 07/22] vhost: alloc shareable log

[Marc-André Lureau]

Hi

On Mon, Sep 21, 2015 at 9:29 PM, Michael S. Tsirkin <address@hidden> wrote:
>> Can this be considered a future enhancement?
>
> What's the big issue? Just count the devices that need a shared one, if
> that count is 0 reallocate with shared == false.


But then it should also VHOST_SET_LOG_BASE all the other devices with
the new log, unless you want to tackle only the future log users. So
it needs to track all the users of the log. Is there a clear benefit
of this? since the memory isn't shared without the memfd passed to
another process and the overhead of memfd is probably quite small, and
pre-shm or future resize will not use the shared memory already.

-- 
Marc-André Lureau