[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 17/24] translate: move real_host_page setting to
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PULL 17/24] translate: move real_host_page setting to -common |
Date: |
Fri, 18 Sep 2015 19:52:06 +0100 |
User-agent: |
Mutt/1.5.23 (2015-06-09) |
* Paolo Bonzini (address@hidden) wrote:
> From: Peter Crosthwaite <address@hidden>
>
> Move the size and mask globals for the "real" host page size to
> translate-common. This is to allow system-level code to use
> REAL_HOST_PAGE_ALIGN and friends in builds which hide translate-all
> behind arch-obj.
Are you intending to move the include definitions as well, because I
still can't use those definitions because they're still in cpu-all.h
which is tainted if I try and include it in anything not target-specific.
Dave
> Cc: address@hidden
> Signed-off-by: Peter Crosthwaite <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> translate-all.c | 2 --
> translate-common.c | 3 +++
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index 0140255..4a9ee33 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -117,8 +117,6 @@ typedef struct PageDesc {
>
> #define V_L1_SHIFT (L1_MAP_ADDR_SPACE_BITS - TARGET_PAGE_BITS - V_L1_BITS)
>
> -uintptr_t qemu_real_host_page_size;
> -uintptr_t qemu_real_host_page_mask;
> uintptr_t qemu_host_page_size;
> uintptr_t qemu_host_page_mask;
>
> diff --git a/translate-common.c b/translate-common.c
> index 681e2bf..619feb4 100644
> --- a/translate-common.c
> +++ b/translate-common.c
> @@ -20,6 +20,9 @@
> #include "qemu-common.h"
> #include "qom/cpu.h"
>
> +uintptr_t qemu_real_host_page_size;
> +uintptr_t qemu_real_host_page_mask;
> +
> #ifndef CONFIG_USER_ONLY
> /* mask must never be zero, except for A20 change call */
> static void tcg_handle_interrupt(CPUState *cpu, int mask)
> --
> 2.5.0
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PULL 14/24] translate-all: Move tcg_handle_interrupt() to -common, (continued)
[Qemu-devel] [PULL 15/24] tcg: split tcg_op_defs to -common, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 09/24] monitor: remove target-specific code from monitor.c, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 18/24] cputlb: move CPU_LOOP() for tlb_reset() to exec.c, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 17/24] translate: move real_host_page setting to -common, Paolo Bonzini, 2015/09/16
- Re: [Qemu-devel] [PULL 17/24] translate: move real_host_page setting to -common,
Dr. David Alan Gilbert <=
[Qemu-devel] [PULL 19/24] cputlb: Change tlb_set_dirty() arg to cpu, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 21/24] monitor: uninclude cpu_ldst, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 24/24] Revert "rcu: init rcu_registry_lock after fork", Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 22/24] checkpatch: Escape left braces in regex, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 23/24] nbd: release exp->blk after all clients are closed, Paolo Bonzini, 2015/09/16
[Qemu-devel] [PULL 20/24] include/exec: Move cputlb exec.c defs out, Paolo Bonzini, 2015/09/16
Re: [Qemu-devel] [PULL 00/24] Misc patches for 2015-09-16, Eric Blake, 2015/09/16
Re: [Qemu-devel] [PULL 00/24] Misc patches for 2015-09-16, Peter Maydell, 2015/09/16