[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] throttle: test that snapshots move
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] throttle: test that snapshots move the throttling configuration |
Date: |
Fri, 18 Sep 2015 17:54:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 17.09.2015 16:33, Alberto Garcia wrote:
> If a snapshot is performed on a device that has I/O limits they should
> be moved to the target image (the new active layer).
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> tests/qemu-iotests/096 | 69
> ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/096.out | 5 ++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 75 insertions(+)
> create mode 100644 tests/qemu-iotests/096
> create mode 100644 tests/qemu-iotests/096.out
Looks good, I'd just like to throw in that 096 is in use by my
looks-dead-but-actually-is-not and
only-waiting-for-the-blockbackend-and-media-series-to-get-merged series
"block: Rework bdrv_close_all()":
http://lists.nongnu.org/archive/html/qemu-block/2015-03/msg00048.html
But then again, once the prerequisites are met, I'll have to send a new
version of that series anyway...
So, since 096 is not a magic number I'm extremely keen on keeping in my
greedy claws:
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature