[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/4] block: support passing 'backing': '' to
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 2/4] block: support passing 'backing': '' to 'blockdev-add' |
|
Date: |
Fri, 18 Sep 2015 08:41:21 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/15/2015 12:42 AM, Alberto Garcia wrote:
> On Tue 15 Sep 2015 04:27:21 AM CEST, Fam Zheng <address@hidden> wrote:
>
>>> + backing = qdict_get_try_str(options, "backing");
>>> + if (backing && *backing == '\0') {
>>> + flags |= BDRV_O_NO_BACKING;
>>> + }
>>> + qdict_del(options, "backing");
>>> +
>
>> Specifying a non-empty "backing" will be a slient nop now, but it used
>> to be an error before. Should we return an error?
>
> Ah, yes, I think it should return an error. Thanks!
With this squashed in,
Reviewed-by: Eric Blake <address@hidden>
>
> --- a/block.c
> +++ b/block.c
> @@ -1473,8 +1473,8 @@ static int bdrv_open_inherit(BlockDriverState
> **pbs, const char *filename,
> backing = qdict_get_try_str(options, "backing");
> if (backing && *backing == '\0') {
> flags |= BDRV_O_NO_BACKING;
> + qdict_del(options, "backing");
> }
> - qdict_del(options, "backing");
>
> Berto
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature