[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 05/26] tests/qapi-schema: Convert test harnes
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v8 05/26] tests/qapi-schema: Convert test harness to QAPISchemaVisitor |
Date: |
Wed, 16 Sep 2015 09:27:50 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/16/2015 05:06 AM, Markus Armbruster wrote:
> The old code prints the result of parsing (list of expression
> dictionaries), and partial results of semantic analysis (list of enum
> dictionaries, list of struct dictionaries).
>
> The new code prints a trace of a schema visit, i.e. what the back-ends
> are going to use. Built-in and array types are omitted, because
> they're boring.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> +class QAPISchemaTestVisitor(QAPISchemaVisitor):
> + def visit_enum_type(self, name, info, values, prefix):
> + print 'enum %s %s prefix=%s' % (name, values, prefix)
> +
> + def visit_object_type(self, name, info, base, members, variants):
> + print 'object %s' % name
> + if base:
> + print ' base %s' % base.name
For consistency with other visitors, I might have done:
if prefix:
print ' prefix %s' % prefix
instead of printing prefix=None for most enums. In particular,
> +enum EnumOne ['value1', 'value2', 'value3'] prefix=None
> +object EventStructOne
> + member struct1: UserDefOne optional=False
> + member string: str optional=False
> + member enum2: EnumOne optional=True
> +object NestedEnumsOne
> + member enum1: EnumOne optional=False
> + member enum2: EnumOne optional=True
> + member enum3: EnumOne optional=False
> + member enum4: EnumOne optional=True
> +enum QEnumTwo ['value1', 'value2'] prefix=QENUM_TWO
the fact that prefix=None and prefix=QENUM_TWO doesn't offer any visual
clues on whether the string was user-supplied, means that the following
would result in ambiguous output:
{ 'enum':'Foo', 'prefix':'None', 'data':[] }
But it's not necessarily a strong enough reason for a respin.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v8 20/26] qapi: Make output visitor return qnull() instead of NULL, (continued)
- [Qemu-devel] [PATCH v8 20/26] qapi: Make output visitor return qnull() instead of NULL, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 17/26] qapi: De-duplicate parameter list generation, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 18/26] qapi-commands: De-duplicate output marshaling functions, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 22/26] qom: Don't use 'gen': false for qom-get, qom-set, object-add, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 09/26] qapi: De-duplicate enum code generation, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 05/26] tests/qapi-schema: Convert test harness to QAPISchemaVisitor, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 15/26] qapi-commands: Rearrange code, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 24/26] qapi: Pseudo-type '**' is now unused, drop it, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 26/26] qapi-introspect: Hide type names, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 21/26] qapi: Introduce a first class 'any' type, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 19/26] qapi: Improve built-in type documentation, Markus Armbruster, 2015/09/16
- [Qemu-devel] [PATCH v8 11/26] qapi-event: Convert to QAPISchemaVisitor, fixing data with base, Markus Armbruster, 2015/09/16