Re: [Qemu-devel] [PATCH 11/12] qapi: add md5 checksum of last dirty bitmap level to query-block

[John Snow]

On 09/15/2015 12:29 PM, Eric Blake wrote:
> On 08/07/2015 03:32 AM, Vladimir Sementsov-Ogievskiy wrote:
>> From: Vladimir Sementsov-Ogievskiy <address@hidden>
>>
>> Reviewed-by: John Snow <address@hidden>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> ---
>>  block.c                | 1 +
>>  include/qemu/hbitmap.h | 8 ++++++++
>>  qapi/block-core.json   | 4 +++-
>>  util/hbitmap.c         | 8 ++++++++
>>  4 files changed, 20 insertions(+), 1 deletion(-)
> 
>> +++ b/qapi/block-core.json
>> @@ -359,11 +359,13 @@
>>  #
>>  # @status: current status of the dirty bitmap (since 2.4)
>>  #
>> +# @md5: md5 checksum of the last bitmap level (since 2.4)
> 
> since 2.5, now. Would it help to be explicit that this is a hexadecimal
> encoding of the checksum (and not the actual binary value)?
> 

I had reasoned that it was implied so as to maintain a valid QMP
protocol stream.