[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v16 18/35] target-tilegx: Handle most bit manipu
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v16 18/35] target-tilegx: Handle most bit manipulation instructions |
Date: |
Tue, 15 Sep 2015 11:02:54 +0100 |
On 14 September 2015 at 23:43, Richard Henderson <address@hidden> wrote:
> The crc instructions are omitted from this set.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target-tilegx/helper.c | 10 +++++++
> target-tilegx/helper.h | 2 ++
> target-tilegx/translate.c | 68
> ++++++++++++++++++++++++++++++++++++++++++++++-
> 3 files changed, 79 insertions(+), 1 deletion(-)
>
> diff --git a/target-tilegx/helper.c b/target-tilegx/helper.c
> index 5b37a8c..a01bb8d 100644
> --- a/target-tilegx/helper.c
> +++ b/target-tilegx/helper.c
> @@ -40,6 +40,16 @@ uint64_t helper_cnttz(uint64_t arg)
> return ctz64(arg);
> }
>
> +uint64_t helper_pcnt(uint64_t arg)
> +{
> + return ctpop64(arg);
> +}
> +
> +uint64_t helper_revbits(uint64_t arg)
> +{
> + return revbit64(arg);
> +}
> +
> /*
> * Functional Description
> * uint64_t a = rf[SrcA];
> diff --git a/target-tilegx/helper.h b/target-tilegx/helper.h
> index fd5517e..644d313 100644
> --- a/target-tilegx/helper.h
> +++ b/target-tilegx/helper.h
> @@ -1,4 +1,6 @@
> DEF_HELPER_2(exception, noreturn, env, i32)
> DEF_HELPER_FLAGS_1(cntlz, TCG_CALL_NO_RWG_SE, i64, i64)
> DEF_HELPER_FLAGS_1(cnttz, TCG_CALL_NO_RWG_SE, i64, i64)
> +DEF_HELPER_FLAGS_1(pcnt, TCG_CALL_NO_RWG_SE, i64, i64)
> +DEF_HELPER_FLAGS_1(revbits, TCG_CALL_NO_RWG_SE, i64, i64)
> DEF_HELPER_FLAGS_3(shufflebytes, TCG_CALL_NO_RWG_SE, i64, i64, i64, i64)
> diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c
> index 6b5de55..c2f38f1 100644
> --- a/target-tilegx/translate.c
> +++ b/target-tilegx/translate.c
> @@ -177,6 +177,43 @@ static void gen_saturate_op(TCGv tdest, TCGv tsrca, TCGv
> tsrcb,
> tcg_temp_free(t0);
> }
>
> +/* Shift the 128-bit value TSRCA:TSRCD riht by the number of bytes
Typo: "right".
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v16 13/35] target-tilegx: Add TILE-Gx building files, (continued)
- [Qemu-devel] [PATCH v16 13/35] target-tilegx: Add TILE-Gx building files, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 12/35] target-tilegx: Generate SEGV properly, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 10/35] target-tilegx: Add several helpers for instructions translation, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 14/35] target-tilegx: Handle simple logical operations, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 15/35] target-tilegx: Handle arithmetic instructions, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 17/35] target-arm: Use new revbit functions, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 16/35] host-utils: Add revbit functions, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 18/35] target-tilegx: Handle most bit manipulation instructions, Richard Henderson, 2015/09/14
- Re: [Qemu-devel] [PATCH v16 18/35] target-tilegx: Handle most bit manipulation instructions,
Peter Maydell <=
- [Qemu-devel] [PATCH v16 11/35] target-tilegx: Framework for decoding bundles, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 19/35] target-tilegx: Handle basic load and store instructions, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 20/35] target-tilegx: Handle post-increment load and store instructions, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 22/35] target-tilegx: Handle conditional branch instructions, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 23/35] target-tilegx: Handle comparison instructions, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 21/35] target-tilegx: Handle unconditional jump instructions, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 25/35] target-tilegx: Handle bitfield instructions, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 24/35] target-tilegx: Implement system and memory management instructions, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 26/35] target-tilegx: Handle shift instructions, Richard Henderson, 2015/09/14
- [Qemu-devel] [PATCH v16 28/35] target-tilegx: Handle scalar multiply instructions, Richard Henderson, 2015/09/14